Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profession parser #77477

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Fix profession parser #77477

merged 1 commit into from
Nov 2, 2024

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Oct 31, 2024

Summary

None

Purpose of change

Text Changes Analyzer fails because professions using copy-from can omit the description field.

Describe the solution

Check if description exists before trying to read it.

Describe alternatives you've considered

Testing

Ran update_pot.sh and it completed successfully.

Additional context

@github-actions github-actions bot added Translation I18n Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [Python] Code made in Python astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 31, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 31, 2024
@Maleclypse Maleclypse merged commit 616900d into CleverRaven:master Nov 2, 2024
14 of 21 checks passed
@mqrause mqrause deleted the parser_fix branch November 2, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants